Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I made the smallest possible changes to make
go-astiav
work withFFmpeg n6.1.1
. It is merely a proof of concept: for tasks limited to simple encoding, decoding, and filtering, most of the library's code works effectively.It must be stated that this library is absolutely not ready for merging, nor will it be in the future. There are many breaking changes from FFmpeg 5.x -> 6.x that need to be adapted, such as:
And other new APIs, etc.
Another issue that must be considered is that its changes are significant enough to affect any project currently using
go-astiav
, so it definitely should not be merged.But this fork will not receive any maintenance or updates. For anyone interested in using FFmpeg Bindings in Go, the only correct choice is still asticode/go-astiav.
Have fun :)
P.S. I wrote this just to make
go-astiav
work withffmpeg-rockchip
so that it can utilize the hardware encoder/decoder on my RK3588 board.EDIT:
Now you could clone Quentin's great branch [bump/n6.1.1] built with
FFmpeg n6.1.1
👍.In your project's go.mod